[webkit-reviews] review granted: [Bug 227582] WebGL video to texture upload spends time clearing the uploaded-to texture : [Attachment 432690] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 227582: WebGL video to texture upload spends time clearing the uploaded-to
texture
https://bugs.webkit.org/show_bug.cgi?id=227582

Attachment 432690: Patch

https://bugs.webkit.org/attachment.cgi?id=432690&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 432690
  --> https://bugs.webkit.org/attachment.cgi?id=432690
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432690&action=review

Very nice investigation and work. r+ with one small comment.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:271
> +	   // WebGL requires that all resources are cleared at creation.

Could you add a comment here that performing robust resource initialization in
the VideoTextureCopier adds a large amount of overhead?