[webkit-reviews] review granted: [Bug 227597] Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px : [Attachment 432734] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 227597: Web Inspector: [Regression: r279271] Sources: Breakpoints section
in navigation sidebar disappears when Web Inspector becomes taller than 650px
https://bugs.webkit.org/show_bug.cgi?id=227597

Attachment 432734: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=432734&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 432734
  --> https://bugs.webkit.org/attachment.cgi?id=432734
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=432734&action=review

r=me, nice catch :)

I wonder how many other bugs there are like this :(

>
Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css:-13
4
> -	   height: 100%;

I think we may want a `flex-basis: 100%` or something here.  The idea behind
this and the code below it is that we give priority to things higher in the
sidebar than lower, so if the developer is decreasing the height of the Web
Inspector window, we don't want the Call Stack section to start collapsing
until after the Breakpoints section has started collapsing.