[webkit-reviews] review granted: [Bug 227599] loadSimulatedRequest: should do same delegate callbacks as loadHTMLString and loadData : [Attachment 432731] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 1 15:26:48 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227599: loadSimulatedRequest: should do same delegate callbacks as
loadHTMLString and loadData
https://bugs.webkit.org/show_bug.cgi?id=227599

Attachment 432731: Patch

https://bugs.webkit.org/attachment.cgi?id=432731&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 432731
  --> https://bugs.webkit.org/attachment.cgi?id=432731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432731&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewLoadAPIs.mm:97
> +	   EXPECT_EQ(vector.size(), 4u);

ASSERT_EQ() as we'll crash otherwise.


More information about the webkit-reviews mailing list