[webkit-reviews] review granted: [Bug 227508] Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir : [Attachment 432701] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227508: Remove unnecessary canBeInternal invocations to mitigate the cost
of potential unmatched patterns in B3LowerToAir
https://bugs.webkit.org/show_bug.cgi?id=227508

Attachment 432701: Patch

https://bugs.webkit.org/attachment.cgi?id=432701&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 432701
  --> https://bugs.webkit.org/attachment.cgi?id=432701
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432701&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   The bit pattern doesn't cause the worst code generation in the
all-internals-are-captured 
> +	   case. So, they don't need canBeInternal checks which might terminate
potential matched 
> +	   scenarios.

Nit: doesn't cause the worst => doesn't cause worse.