[webkit-reviews] review granted: [Bug 221098] Lazily create m_windowCloseWatchpoints so we don't mistakenly think we have a frame when re-associating a document to a given cached frame : [Attachment 418791] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 221098: Lazily create m_windowCloseWatchpoints so we don't mistakenly think
we have a frame when re-associating a document to a given cached frame
https://bugs.webkit.org/show_bug.cgi?id=221098

Attachment 418791: patch

https://bugs.webkit.org/attachment.cgi?id=418791&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 418791
  --> https://bugs.webkit.org/attachment.cgi?id=418791
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418791&action=review

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:250
> +    // Because this can only happen once, we don't need to consider a
potential ping-ponging
> +    // between states of having a frame or not having a frame.

This is a bit misleading. It's possible for DOMWindow::frame() to temporarily
return nullptr while it's inside a page cache.
Maybe rephrase it as once the frame is *destroyed* and that DOMWindow can be
associated with at most one frame in its lifetime?