[webkit-reviews] review granted: [Bug 218896] Remove unused functions from GraphicsContextGL and ExtensionsGL : [Attachment 418458] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 14:20:32 PST 2021

Dean Jackson <dino at apple.com> has granted Rini Patel <rini_patel at apple.com>'s
request for review:
Bug 218896: Remove unused functions from GraphicsContextGL and ExtensionsGL

Attachment 418458: Patch


--- Comment #51 from Dean Jackson <dino at apple.com> ---
Comment on attachment 418458
  --> https://bugs.webkit.org/attachment.cgi?id=418458

View in context: https://bugs.webkit.org/attachment.cgi?id=418458&action=review

> Source/WebCore/platform/graphics/angle/ExtensionsGLANGLE.cpp:36
> +ExtensionsGLANGLE::ExtensionsGLANGLE(GraphicsContextGLOpenGL* context)

+1 to Darin's comment that this should be a ref parameter/member, but not
important now.

I think Kimmo wants to get rid of ExtensionsGL anyway.

> Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:67
> +    bool isNVIDIA() const { return m_isNVIDIA; }
> +    bool isAMD() const { return m_isAMD; }
> +    bool isIntel() const { return m_isIntel; }
> +    bool isImagination() const { return m_isImagination; }
> +    String vendor() const { return m_vendor; }

It's not relevant for this patch, but I'm surprised that other ports are still
using these.

> Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:495
> +#if !USE(ANGLE)

Is there a case where someone would include this header while using ANGLE?

More information about the webkit-reviews mailing list