[webkit-reviews] review granted: [Bug 220877] Crash in readPixels with ANGLE Metal backend : [Attachment 418692] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 12:04:16 PST 2021


Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 220877: Crash in readPixels with ANGLE Metal backend
https://bugs.webkit.org/show_bug.cgi?id=220877

Attachment 418692: Patch

https://bugs.webkit.org/attachment.cgi?id=418692&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 418692
  --> https://bugs.webkit.org/attachment.cgi?id=418692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418692&action=review

> Source/ThirdParty/ANGLE/ChangeLog:24
> +2021-01-28  Kyle Piddington	<kpiddington at apple.com>
> +
> +	   Need a short description (OOPS!).
> +	   Need the bug URL (OOPS!).
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * src/libANGLE/renderer/metal/RenderBufferMtl.mm:
> +	   (rx::RenderbufferMtl::initializeContents):

Oops! Extra blank changelog entry.

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/RenderBufferMtl.mm:178
> +    if(imageIndex.valid())

Nit: missing space after if.


More information about the webkit-reviews mailing list