[webkit-reviews] review granted: [Bug 220890] [WASM-References] Enable reference types by default : [Attachment 418719] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 11:25:00 PST 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 220890: [WASM-References] Enable reference types by default
https://bugs.webkit.org/show_bug.cgi?id=220890

Attachment 418719: Patch

https://bugs.webkit.org/attachment.cgi?id=418719&action=review




--- Comment #12 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 418719
  --> https://bugs.webkit.org/attachment.cgi?id=418719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418719&action=review

r=me if EWS gets green

>
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any-ex
pected.txt:25
> +FAIL Stray argument WebAssembly.Table.prototype.constructor expects the
second argument to be null or an instance of WebAssembly.Function

OK, this is because WebAssembly tests in WPT is obsolete after
wasm-reference-types.

>
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/constructor.any.wo
rker-expected.txt:25
> +FAIL Stray argument WebAssembly.Table.prototype.constructor expects the
second argument to be null or an instance of WebAssembly.Function

OK, this is because WebAssembly tests in WPT is obsolete after
wasm-reference-types.

>
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any-expect
ed.txt:4
> +FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)"
did not throw

OK, this is because WebAssembly tests in WPT is obsolete after
wasm-reference-types.

>
LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/table/get-set.any.worker
-expected.txt:4
> +FAIL Missing arguments: set assert_throws_js: function "() => table.set(0)"
did not throw

OK, this is because WebAssembly tests in WPT is obsolete after
wasm-reference-types.


More information about the webkit-reviews mailing list