[webkit-reviews] review granted: [Bug 221121] Devirtualize some functions on InputType : [Attachment 418747] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 11:21:26 PST 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 221121: Devirtualize some functions on InputType
https://bugs.webkit.org/show_bug.cgi?id=221121

Attachment 418747: Patch

https://bugs.webkit.org/attachment.cgi?id=418747&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 418747
  --> https://bugs.webkit.org/attachment.cgi?id=418747
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418747&action=review

r=me

> Source/WebCore/html/InputType.h:162
> +    bool isDateTimeField() const { return false; }

Let's remove this `isDateTimeField` since "input datetime" is not supported in
WebKit, and possibly never supported since it is deprecated.

> Source/WebCore/html/InputType.h:322
>      virtual bool isEnumeratable();

Let's make isEnumeratable non-virtual since it is no longer using virtual
overrides.


More information about the webkit-reviews mailing list