[webkit-reviews] review granted: [Bug 221123] Add plumbing to allow AppHighlights to be restored. : [Attachment 418710] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 221123: Add plumbing to allow AppHighlights to be restored.
https://bugs.webkit.org/show_bug.cgi?id=221123

Attachment 418710: Patch

https://bugs.webkit.org/attachment.cgi?id=418710&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 418710
  --> https://bugs.webkit.org/attachment.cgi?id=418710
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418710&action=review

LGTM with Tim's comments.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2048
> +    _page->restoreAppHighlights(WTFMove(buffer));

Nit - I would just write this as
`_page->restoreAppHighlights(WebCore::SharedBuffer::create(data));`.