[webkit-reviews] review granted: [Bug 220946] [css-flexbox] REGRESSION(r266695): content inside a `<button>` inside a flex container has a height of `0` without a declared `min-height` : [Attachment 418634] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Sergio Villar Senin <svillar at igalia.com>'s
request for review:
Bug 220946: [css-flexbox] REGRESSION(r266695): content inside a `<button>`
inside a flex container has a height of `0` without a declared `min-height`
https://bugs.webkit.org/show_bug.cgi?id=220946

Attachment 418634: Patch

https://bugs.webkit.org/attachment.cgi?id=418634&action=review




--- Comment #9 from zalan <zalan at apple.com> ---
Comment on attachment 418634
  --> https://bugs.webkit.org/attachment.cgi?id=418634
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418634&action=review

> Source/WebCore/ChangeLog:14
> +	   FlexibleBoxImpl's like RenderButton wrap their DOM children in
anonymous blocks. Those anonymous blocks are

Is it really always the case? -and what exactly do you mean by DOM children.
This is the render tree, we don't have DOM objects here.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1639
> +	   auto* descendants = percentHeightDescendants();

I'd prefer writing it out like this
auto& descendants = *percentHeightDescendants();
so that if "descendants" is later used in this function no one starts null
checking it.