[webkit-reviews] review denied: [Bug 221035] [MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess : [Attachment 418628] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 28 12:01:56 PST 2021

Sam Weinig <sam at webkit.org> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 221035: [MacOS] Enable WebKitTestRunner audio and video capture in

Attachment 418628: Patch


--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 418628
  --> https://bugs.webkit.org/attachment.cgi?id=418628

View in context: https://bugs.webkit.org/attachment.cgi?id=418628&action=review

> Tools/WebKitTestRunner/TestController.cpp:933
> +    WKPreferencesSetCaptureAudioInGPUProcessEnabled(preferences, true);
> +    WKPreferencesSetCaptureVideoInGPUProcessEnabled(preferences, true);
> +#endif

Please keep this in TestOptions.cpp. Trying to have all the state in one place
moving away from having it here.

More information about the webkit-reviews mailing list