[webkit-reviews] review granted: [Bug 220964] [GPUP][MSE] A video element does not fire “canplaythrough” event if SourceBuffer.abort() is called : [Attachment 418623] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 220964: [GPUP][MSE] A video element does not fire “canplaythrough” event if
SourceBuffer.abort() is called
https://bugs.webkit.org/show_bug.cgi?id=220964

Attachment 418623: Patch

https://bugs.webkit.org/attachment.cgi?id=418623&action=review




--- Comment #14 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 418623
  --> https://bugs.webkit.org/attachment.cgi?id=418623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418623&action=review

r=me, with nit:

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:406
> +	       for (auto trackIdMediaSamplePair : m_mediaSamples) {

This...

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:415
> +	       m_mediaSamples.clear();

...and this could probably be merged together into something more like:

auto samples = WTFMove(m_mediaSamples);
for (auto trackIdMediaSamplePair : samples) {

And I know this isn't an issue for this particular code, but insulates
m_mediaSamples from being modified while iterating in the future.