[webkit-reviews] review granted: [Bug 221088] [macOS] Crash when updating color preferences : [Attachment 418644] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 221088: [macOS] Crash when updating color preferences
https://bugs.webkit.org/show_bug.cgi?id=221088

Attachment 418644: Patch

https://bugs.webkit.org/attachment.cgi?id=418644&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 418644
  --> https://bugs.webkit.org/attachment.cgi?id=418644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418644&action=review

r=me, though I think a comment or changed function name might be helpful.

> Source/WebKit/ChangeLog:12
> +	   WebContent process.

Do you mean UIProcess here? I think the preference updates are expected in
UIProcess, and we should never attempt to make such updates in the WCP.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:188
> +static void updateCanQuitQuietlyAndSafely(NSApplication*, SEL)

Perhaps this would be clearer with a better name, rather than a comment like I
suggested below:

static void
preventAppKitFromContactingLaunchServicesFromWebContentProcess(NSApplication*,
SEL)

... or maybe you can think of a better name.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:189
> +{

Perhaps a comment here would be useful:

// WebKit prohibits communication with Launch Services after entering the
sandbox. This method override prevents AppKit
// in the WebContent process from attempting to set color preferences. Color
preferences are instead handled in the UIProcess.