[webkit-reviews] review requested: [Bug 219325] [WPE][GTK] flatpak-spawn subsandbox clears environment variables, breaks EphyPermissionsManager : [Attachment 418591] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 28 08:53:47 PST 2021


Michael Catanzaro <mcatanzaro at gnome.org> has asked  for review:
Bug 219325: [WPE][GTK] flatpak-spawn subsandbox clears environment variables,
breaks EphyPermissionsManager
https://bugs.webkit.org/show_bug.cgi?id=219325

Attachment 418591: Patch

https://bugs.webkit.org/attachment.cgi?id=418591&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 418591
  --> https://bugs.webkit.org/attachment.cgi?id=418591
Patch

OK, I can't actually test it with run-minibrowser because it doesn't run a real
flatpak environment. It just does this:

$ run-minibrowser --gtk
Portal call failed: Authorization error: Key file does not have group
“Application”
Portal call failed: Authorization error: Key file does not have group
“Application”

** (MiniBrowser:21): WARNING **: 08:52:21.529: WebProcess CRASHED


This shouldn't happen in a real flatpak though. I think this is safe to land.


More information about the webkit-reviews mailing list