[webkit-reviews] review granted: [Bug 220654] [GStreamer][Playbin3] Support for CEA-608 closed captioned media : [Attachment 418546] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220654: [GStreamer][Playbin3] Support for CEA-608 closed captioned media
https://bugs.webkit.org/show_bug.cgi?id=220654

Attachment 418546: Patch

https://bugs.webkit.org/attachment.cgi?id=418546&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 418546
  --> https://bugs.webkit.org/attachment.cgi?id=418546
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418546&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93
> +	       WTFLogAlways("GStreamer closedcaption plugins are missing.
Please install gst-plugins-bad and gst-plugins-rs");

I would GST_ERROR on this as well, but up to you.