[webkit-reviews] review granted: [Bug 221058] [iOS] add accessibility image extraction contextmenu item for revealing images : [Attachment 418583] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 27 14:41:18 PST 2021
Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 221058: [iOS] add accessibility image extraction contextmenu item for
revealing images
https://bugs.webkit.org/show_bug.cgi?id=221058
Attachment 418583: Patch
https://bugs.webkit.org/attachment.cgi?id=418583&action=review
--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 418583
--> https://bugs.webkit.org/attachment.cgi?id=418583
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=418583&action=review
> Source/WebKit/UIProcess/API/Cocoa/_WKElementActionInternal.h:41
> +#if ENABLE(IMAGE_EXTRACTION)
> ++ (UIImage *)imageForElementActionTypeImageExtraction;
> ++ (UIImage *)imageForElementActionTypeRevealImage;
> +#endif
Since these methods are only used inside _WKElementAction.mm, you don't need to
declare them in this internal header as well.
More information about the webkit-reviews
mailing list