[webkit-reviews] review granted: [Bug 220971] REGRESSION (r243266): SVGStopElement does not react upon 'offset' attribute changes : [Attachment 418514] Patch, v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 11:53:27 PST 2021


Said Abou-Hallawa <sabouhallawa at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 220971: REGRESSION (r243266): SVGStopElement does not react upon 'offset'
attribute changes
https://bugs.webkit.org/show_bug.cgi?id=220971

Attachment 418514: Patch, v2

https://bugs.webkit.org/attachment.cgi?id=418514&action=review




--- Comment #6 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 418514
  --> https://bugs.webkit.org/attachment.cgi?id=418514
Patch, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=418514&action=review

> LayoutTests/svg/custom/deep-dynamic-updates.svg:28
> +	       requestAnimationFrame(() => testRunner.notifyDone());

I think this rAF is not needed. WTR and DRT both make sure the page is updated
before getting the result image. But I think it is okay to keep it.


More information about the webkit-reviews mailing list