[webkit-reviews] review granted: [Bug 221039] [macOS] Re-enable ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS : [Attachment 418555] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 09:53:51 PST 2021


Brent Fulgham <bfulgham at webkit.org> has granted  review:
Bug 221039: [macOS] Re-enable
ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS
https://bugs.webkit.org/show_bug.cgi?id=221039

Attachment 418555: Patch

https://bugs.webkit.org/attachment.cgi?id=418555&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 418555
  --> https://bugs.webkit.org/attachment.cgi?id=418555
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418555&action=review

r=me

>> Source/WebCore/platform/mac/ThemeMac.mm:72
>> +}
> 
> I don't think this is an intended part of your change.

Oh! I see, this was intentional!

>> Source/WebCore/platform/mac/ThemeMac.mm:82
>> +	    styleMask:NSWindowStyleMaskBorderless
backing:NSBackingStoreBuffered defer:YES];
> 
> I don't think this is an intended part of your change.

I'm wrong -- you explained in your Changelog. Sorry for not catching that.


More information about the webkit-reviews mailing list