[webkit-reviews] review denied: [Bug 221039] [macOS] Re-enable ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS : [Attachment 418555] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 27 09:44:40 PST 2021


Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 221039: [macOS] Re-enable
ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS
https://bugs.webkit.org/show_bug.cgi?id=221039

Attachment 418555: Patch

https://bugs.webkit.org/attachment.cgi?id=418555&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 418555
  --> https://bugs.webkit.org/attachment.cgi?id=418555
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418555&action=review

The relevant parts of this patch look good, but it seems like some unrelated
work got included. Can you fix the patch?

> Source/WebCore/platform/mac/ThemeMac.mm:72
> +}

I don't think this is an intended part of your change.

> Source/WebCore/platform/mac/ThemeMac.mm:82
> +	   styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered
defer:YES];

I don't think this is an intended part of your change.


More information about the webkit-reviews mailing list