[webkit-reviews] review granted: [Bug 220941] [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on : [Attachment 418322] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 12:41:07 PST 2021


Fujii Hironori <Hironori.Fujii at sony.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 220941: [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on
https://bugs.webkit.org/show_bug.cgi?id=220941

Attachment 418322: Patch

https://bugs.webkit.org/attachment.cgi?id=418322&action=review




--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 418322
  --> https://bugs.webkit.org/attachment.cgi?id=418322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review

> Source/cmake/OptionsWin.cmake:90
> +    WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)

Nice. However, this is a breaking change. But, I think no WinCairo users are
affected.


More information about the webkit-reviews mailing list