[webkit-reviews] review granted: [Bug 220944] Expose the value of `<meta name="theme-color" content="...">` as SPI : [Attachment 418457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 12:00:10 PST 2021


Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 220944: Expose the value of `<meta name="theme-color" content="...">` as
SPI
https://bugs.webkit.org/show_bug.cgi?id=220944

Attachment 418457: Patch

https://bugs.webkit.org/attachment.cgi?id=418457&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 418457
  --> https://bugs.webkit.org/attachment.cgi?id=418457
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418457&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3911
> +    layerTransaction.setThemeColor(corePage()->themeColor());

Should this reset m_pendingThemeColorChange? I guess it doesn't matter, it's
just a bit funny that it gets stuck if UI-side compositing is on.


More information about the webkit-reviews mailing list