[webkit-reviews] review granted: [Bug 220862] REGRESSION (r271584): Hovering slowly over and out of "Top 100" items on liberation.fr does not restore animated state : [Attachment 418409] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 11:33:35 PST 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 220862: REGRESSION (r271584): Hovering slowly over and out of "Top 100"
items on liberation.fr does not restore animated state
https://bugs.webkit.org/show_bug.cgi?id=220862

Attachment 418409: patch

https://bugs.webkit.org/attachment.cgi?id=418409&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 418409
  --> https://bugs.webkit.org/attachment.cgi?id=418409
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418409&action=review

> Source/WebCore/dom/Document.cpp:7234
> +	   Style::PseudoClassChangeInvalidation
styleInvalidation(*elementsToClearActive.last(),
CSSSelector::PseudoClassActive, Style::InvalidationScope::Descendants);
> +	   for (auto& element : elementsToClearActive)
> +	       element->setActive(false, false,
Style::InvalidationScope::SelfChildrenAndSiblings);

Maybe share these almost-duplicate chunks with some lambdas?


More information about the webkit-reviews mailing list