[webkit-reviews] review granted: [Bug 220973] [MacOS] Enable NSURLSession WebSocket code path in WebKitTestRunner : [Attachment 418407] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 09:43:29 PST 2021

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 220973: [MacOS] Enable NSURLSession WebSocket code path in WebKitTestRunner

Attachment 418407: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 418407
  --> https://bugs.webkit.org/attachment.cgi?id=418407

View in context: https://bugs.webkit.org/attachment.cgi?id=418407&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1038
> +	   // FIXME: reenable below ASSERT once rdar://problem/72383646 is

Better grammar would be:

    // FIXME: We can re-enable ASSERT below once NSURLSession bug
rdar://problem/72383646 is fixed.

Ideally the comment makes it clear or at least implies that it’s not urgent to
re-enable the assertion and there’s no detectable symptom of the bug.

More information about the webkit-reviews mailing list