[webkit-reviews] review granted: [Bug 220952] [macOS] Close all XPC connections to Launch Services after checking in : [Attachment 418344] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 220952: [macOS] Close all XPC connections to Launch Services after checking
in
https://bugs.webkit.org/show_bug.cgi?id=220952

Attachment 418344: Patch

https://bugs.webkit.org/attachment.cgi?id=418344&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 418344
  --> https://bugs.webkit.org/attachment.cgi?id=418344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418344&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:323
> +    // FIXME: Replace the constant 4 with
kLSServerConnectionStatusReleaseNotificationsMask when available in the SDK.

Can you add a Bugzilla here so we don't forget?

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:459
> +    if (!m_networkProcessConnection)

This feels very unusual. Should we log when this happens?

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:746
> +    if (!m_networkProcessConnection)

Ditto. Updating activate page information when the network process is dead
seems unusual. Might be worth logging in case it is relevant to user-visible
bugs.