[webkit-reviews] review granted: [Bug 220781] [Flatpak SDK] Flatpak 1.10 environment variable issues : [Attachment 418395] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted  review:
Bug 220781: [Flatpak SDK] Flatpak 1.10 environment variable issues
https://bugs.webkit.org/show_bug.cgi?id=220781

Attachment 418395: Patch

https://bugs.webkit.org/attachment.cgi?id=418395&action=review




--- Comment #8 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 418395
  --> https://bugs.webkit.org/attachment.cgi?id=418395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418395&action=review

>> Tools/flatpak/flatpakutils.py:856
>> +		    if self.flatpak_version >= (1, 10, 0):
> 
> A version check is not necessarily right, would be better to check the
existence of the option instead. I'll revisit this part.

A version check is quite likely safer and more robust than trying to parse the
output of “flatpak --help” — I think it's okay to leave it like thi =)