[webkit-reviews] review canceled: [Bug 220781] [Flatpak SDK] Flatpak 1.10 environment variable issues : [Attachment 418395] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 26 05:40:37 PST 2021
Philippe Normand <pnormand at igalia.com> has canceled Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220781: [Flatpak SDK] Flatpak 1.10 environment variable issues
https://bugs.webkit.org/show_bug.cgi?id=220781
Attachment 418395: Patch
https://bugs.webkit.org/attachment.cgi?id=418395&action=review
--- Comment #7 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 418395
--> https://bugs.webkit.org/attachment.cgi?id=418395
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=418395&action=review
> Tools/flatpak/flatpakutils.py:856
> + if self.flatpak_version >= (1, 10, 0):
A version check is not necessarily right, would be better to check the
existence of the option instead. I'll revisit this part.
More information about the webkit-reviews
mailing list