[webkit-reviews] review granted: [Bug 220938] [GLIB] API tests fail to report harness failures : [Attachment 418366] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 220938: [GLIB] API tests fail to report harness failures
https://bugs.webkit.org/show_bug.cgi?id=220938

Attachment 418366: Patch

https://bugs.webkit.org/attachment.cgi?id=418366&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 418366
  --> https://bugs.webkit.org/attachment.cgi?id=418366
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418366&action=review

Good catch, thanks!

> Tools/glib/glib_test_runner.py:272
> +	   if (not self._results) and p.returncode != 0:

Do we need the parentheses here?

> Tools/glib/glib_test_runner.py:278
> +	   elif p.returncode != 0 and not need_restart:  # Try to read errors
from afterAll

Don't use else after a return