[webkit-reviews] review granted: [Bug 220956] Crash when remote inspecting in debug builds : [Attachment 418355] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 220956: Crash when remote inspecting in debug builds
https://bugs.webkit.org/show_bug.cgi?id=220956

Attachment 418355: Patch

https://bugs.webkit.org/attachment.cgi?id=418355&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 418355
  --> https://bugs.webkit.org/attachment.cgi?id=418355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418355&action=review

r=me, nice fix!

>
Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:2
07
> +	       if (targetIdentifier)

Why was this added?  `RemoteInspector::updateTargetListing` should be able to
handle `0`.