[webkit-reviews] review granted: [Bug 220933] [iOS] improve support for sequential scribble interactions that involving different inputs : [Attachment 418308] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 220933: [iOS] improve support for sequential scribble interactions that
involving different inputs
https://bugs.webkit.org/show_bug.cgi?id=220933

Attachment 418308: Patch

https://bugs.webkit.org/attachment.cgi?id=418308&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 418308
  --> https://bugs.webkit.org/attachment.cgi?id=418308
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418308&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:399
> +    uint64_t _activeTextInteractionCount;

That's a lot of active text interactions!

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5351
> +    --_activeTextInteractionCount;

How sure are you this will never underflow? Maybe an assertion at a minimum?