[webkit-reviews] review granted: [Bug 220509] [SOUP] Stop using SoupRequest API to load files in preparation for libsoup3 : [Attachment 417960] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 25 07:16:19 PST 2021
Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 220509: [SOUP] Stop using SoupRequest API to load files in preparation for
libsoup3
https://bugs.webkit.org/show_bug.cgi?id=220509
Attachment 417960: Patch
https://bugs.webkit.org/attachment.cgi?id=417960&action=review
--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 417960
--> https://bugs.webkit.org/attachment.cgi?id=417960
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=417960&action=review
> Source/WebKit/NetworkProcess/soup/Resources/directory.css:1
> +:root {
Could we at least add a comment mentioning that this file comes from
libsoup and that therefore it's assumed that it has a license compatible
with WebKit's?
Other than this detail, I think the patch can be landed.
More information about the webkit-reviews
mailing list