[webkit-reviews] review granted: [Bug 220733] [css-grid] max-height percentages are wrongly resolved for replaced grid items : [Attachment 418148] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 220733: [css-grid] max-height percentages are wrongly resolved for replaced
grid items
https://bugs.webkit.org/show_bug.cgi?id=220733

Attachment 418148: Patch

https://bugs.webkit.org/attachment.cgi?id=418148&action=review




--- Comment #9 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 418148
  --> https://bugs.webkit.org/attachment.cgi?id=418148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418148&action=review

r=me, thanks for the changes.

> Source/WebCore/rendering/RenderBox.cpp:3187
> +	   if (overridingContainingBlockContentLogicalHeight() ==
LayoutUnit(-1))
> +	       return true;
> +	   return false;

Nit: It's more common to write this like:
    return overridingContainingBlockContentLogicalHeight() == LayoutUnit(-1);

In that case you won't need the braces on the if either.