[webkit-reviews] review granted: [Bug 220732] Complete WebXRRigidTransform implementation : [Attachment 418143] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 25 01:32:47 PST 2021
Sergio Villar Senin <svillar at igalia.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 220732: Complete WebXRRigidTransform implementation
https://bugs.webkit.org/show_bug.cgi?id=220732
Attachment 418143: Patch
https://bugs.webkit.org/attachment.cgi?id=418143&action=review
--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 418143
--> https://bugs.webkit.org/attachment.cgi?id=418143
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=418143&action=review
> Source/WebCore/Modules/webxr/WebXRRigidTransform.cpp:131
> + // If the operation IsDetachedBuffer on internal matrix is false, return
transformâs internal matrix.
Nit: I think the code is self explanatory here, maybe we don't need the
comment.
> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:584
> +// TODO: Once https://bugs.webkit.org/show_bug.cgi?id=220856 is addressed we
can reuse this function in TransformationMatrix::recompose4().
Nit: in WebKit we normally use FIXME instead of TODO
More information about the webkit-reviews
mailing list