[webkit-reviews] review denied: [Bug 220781] [Flatpak SDK] Flatpak 1.10 environment variable issues : [Attachment 418118] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 00:44:16 PST 2021

Adrian Perez <aperez at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 220781: [Flatpak SDK] Flatpak 1.10 environment variable issues

Attachment 418118: Patch


--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 418118
  --> https://bugs.webkit.org/attachment.cgi?id=418118

View in context: https://bugs.webkit.org/attachment.cgi?id=418118&action=review

> Tools/flatpak/flatpakutils.py:854
> +	       if envvar.startswith("LC"):

It would be safer to list the local-related LC_* variable names only:

  if envvar in ("LC_CTYPE=", "LC_NUMERIC", "LC_TIME", "LC_COLLATE",

If the above feels like too much of a mouthful (though I think it's fine),
at least I would make this check “.startswith("LC_")” — to make sure some
other variable like “LCFOO” is not accidentally picked by the loop.

Also: This check does not match the “LANG” variable, which can also be
used to setup locale attributes. Is that on purpose, or maybe missing a
check here?

More information about the webkit-reviews mailing list