[webkit-reviews] review granted: [Bug 220888] [JSC] DeferredWorkTimer should clear pending task after running : [Attachment 418220] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 220888: [JSC] DeferredWorkTimer should clear pending task after running
https://bugs.webkit.org/show_bug.cgi?id=220888

Attachment 418220: Patch

https://bugs.webkit.org/attachment.cgi?id=418220&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 418220
  --> https://bugs.webkit.org/attachment.cgi?id=418220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review

r=me

> Source/JavaScriptCore/runtime/JSPromise.cpp:-186
> -    vm.deferredWorkTimer->cancelPendingWork(this);

Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()?  I see
that you've removed all calls to it.  If not, we should remove it.