[webkit-reviews] review granted: [Bug 220846] WebGL powerPreference is not tested : [Attachment 418113] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 23 00:25:02 PST 2021
Kenneth Russell <kbr at google.com> has granted review:
Bug 220846: WebGL powerPreference is not tested
https://bugs.webkit.org/show_bug.cgi?id=220846
Attachment 418113: Patch
https://bugs.webkit.org/attachment.cgi?id=418113&action=review
--- Comment #2 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 418113
--> https://bugs.webkit.org/attachment.cgi?id=418113
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=418113&action=review
Looks good to me. r+
> LayoutTests/fast/canvas/webgl/high-performance-context.html:14
> +description("Tests that a high-performance contexts do not fail.");
"contexts do not" -> "context does not"
> LayoutTests/fast/canvas/webgl/high-performance-context.html:19
> +var wtu = WebGLTestUtils;
Nowadays, prefer "let" (or "const") over "var".
More information about the webkit-reviews
mailing list