[webkit-reviews] review granted: [Bug 220869] Nullptr dereference in SpeechRecognition::stop() : [Attachment 418205] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted  review:
Bug 220869: Nullptr dereference in SpeechRecognition::stop()
https://bugs.webkit.org/show_bug.cgi?id=220869

Attachment 418205: Patch

https://bugs.webkit.org/attachment.cgi?id=418205&action=review




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 418205
  --> https://bugs.webkit.org/attachment.cgi?id=418205
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418205&action=review

> LayoutTests/fast/speechrecognition/detached-iframe.html:8
> +
> +

Two blank lines.

> LayoutTests/fast/speechrecognition/detached-iframe.html:11
> +if (window.testRunner) {
> +    jsTestIsAsync = true;
> +}

No curly braces around a single line statement.

> LayoutTests/fast/speechrecognition/detached-iframe.html:14
> +	var frame = document.getElementById('iframe');

Use const?