[webkit-reviews] review granted: [Bug 219097] The web process should be killed after failing to decode display list items in the GPU process : [Attachment 418197] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 219097: The web process should be killed after failing to decode display
list items in the GPU process
https://bugs.webkit.org/show_bug.cgi?id=219097

Attachment 418197: Patch

https://bugs.webkit.org/attachment.cgi?id=418197&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 418197
  --> https://bugs.webkit.org/attachment.cgi?id=418197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418197&action=review

Much nicer IMO

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:49
> +   
m_gpuConnectionToWebProcess->gpuProcess().parentProcessConnection()->send(Messa
ges::GPUProcessProxy::TerminateWebProcess(m_gpuConnectionToWebProcess->webProce
ssIdentifier()), 0);

We may want to add a terminateWebProcess() function to
GPUConnectionToWebProcess to not have to duplicate this logic in 2 places.