[webkit-reviews] review granted: [Bug 220868] REGRESSION (r271731): Unchecked JS exception under GlobalObject::moduleLoaderFetch : [Attachment 418179] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 22 14:52:15 PST 2021


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 220868: REGRESSION (r271731): Unchecked JS exception under
GlobalObject::moduleLoaderFetch
https://bugs.webkit.org/show_bug.cgi?id=220868

Attachment 418179: Patch

https://bugs.webkit.org/attachment.cgi?id=418179&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 418179
  --> https://bugs.webkit.org/attachment.cgi?id=418179
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418179&action=review

r=me

> Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp:244
> +	       JSC::instantiate(vm, globalObject, promise, module,
importObject, moduleKey, resolveKind, creationMode);

I think we don't need this JSC:: qualifier.


More information about the webkit-reviews mailing list