[webkit-reviews] review granted: [Bug 220852] DumpRenderTree behaves differently to WebKitTestRunner wrt integrated/discrete GPU behavior : [Attachment 418122] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 220852: DumpRenderTree behaves differently to WebKitTestRunner wrt
integrated/discrete GPU behavior
https://bugs.webkit.org/show_bug.cgi?id=220852

Attachment 418122: Patch

https://bugs.webkit.org/attachment.cgi?id=418122&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 418122
  --> https://bugs.webkit.org/attachment.cgi?id=418122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418122&action=review

I didn't know about this key, and this is an excellent thing to consider. Just
to confirm, this changes nothing on the bots, correct?

Presumably most Legacy WebKit clients don't have
NSSupportsAutomaticGraphicsSwitching in their plists, so we should continue to
test WebGL with discrete GPU on bots that have it.

> Tools/ChangeLog:12
> +	   * DumpRenderTree/Info.plist: Added.

This file should be in DumpRenderTree/mac.

> Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:1416
>			baseConfigurationReference = BCB281F00CFA713D007E533E
/* DumpRenderTree.xcconfig */;
>			buildSettings = {
> +				CREATE_INFOPLIST_SECTION_IN_BINARY = YES;
> +				INFOPLIST_FILE = "$(SRCROOT)/Info.plist";

Even though iOS has this in .xcodeproj, adding configurations to xcodeproj
makes me cringe. Normally, everything should be in .xcconfig.