[webkit-reviews] review granted: [Bug 220657] [css-grid] Relayout grid items when definiteness changes. : [Attachment 418035] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 220657: [css-grid] Relayout grid items when definiteness changes.
https://bugs.webkit.org/show_bug.cgi?id=220657

Attachment 418035: Patch

https://bugs.webkit.org/attachment.cgi?id=418035&action=review




--- Comment #10 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 418035
  --> https://bugs.webkit.org/attachment.cgi?id=418035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418035&action=review

r=me with the requested changes inline.

> Source/WebCore/ChangeLog:8
> +	   When setting an overide logical-height the definiteness can change
causing %-height

Nit: s/overide/override/

> Source/WebCore/ChangeLog:-12
> -	   * rendering/RenderGrid.cpp:
> -	   (WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
> -

I guess this was a mistake, you shouldn't change other parts of the ChangeLog.

> Source/WebCore/rendering/RenderGrid.cpp:1142
> +	   // Checking the logical-height of a child isn't enough. Setting an
override ogical-height

s/ogical/logical/

> LayoutTests/TestExpectations:-3970
> -webkit.org/b/212246
imported/w3c/web-platform-tests/css/css-grid/grid-child-percent-basis-resize-1.
html [ ImageOnlyFailure ]

I believe you have to reflect this in LayoutTests/ChangeLog.