[webkit-reviews] review granted: [Bug 220820] [JSC] JSPromise should not propagate TerminatedExecutionError : [Attachment 418091] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 220820: [JSC] JSPromise should not propagate TerminatedExecutionError
https://bugs.webkit.org/show_bug.cgi?id=220820

Attachment 418091: Patch

https://bugs.webkit.org/attachment.cgi?id=418091&action=review




--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 418091
  --> https://bugs.webkit.org/attachment.cgi?id=418091
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418091&action=review

r=me

>> Source/JavaScriptCore/API/JSAPIGlobalObject.mm:167
>> +	promise->reject(globalObject, createError(globalObject,
result.error()));
> 
> Shouldn't you only reject the promise if an exception actually exists?

Sorry, I misread this.	Ignore me.