[webkit-reviews] review denied: [Bug 220792] [webkitcorepy] Use AutoInstall for webkitcorepy deps as well : [Attachment 418033] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 06:53:55 PST 2021


Jonathan Bedard <jbedard at apple.com> has denied Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 220792: [webkitcorepy] Use AutoInstall for webkitcorepy deps as well
https://bugs.webkit.org/show_bug.cgi?id=220792

Attachment 418033: Patch

https://bugs.webkit.org/attachment.cgi?id=418033&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 418033
  --> https://bugs.webkit.org/attachment.cgi?id=418033
Patch

In most places, this would be the right approach, but webkitcorepy is a special
case because it’s imported before the autoinstaller is configured (and not just
in webkitpy, that’s also true in some Apple non-public code)

What I should have done is put the six import in task_pool inside the function
(or functions) that are actually using it. If no one else posts a patch, I’ll
get to it in the next hour or two.


More information about the webkit-reviews mailing list