[webkit-reviews] review granted: [Bug 220769] EWS should display commit identifier in builds : [Attachment 417995] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 220769: EWS should display commit identifier in builds
https://bugs.webkit.org/show_bug.cgi?id=220769

Attachment 417995: Patch

https://bugs.webkit.org/attachment.cgi?id=417995&action=review




--- Comment #3 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 417995
  --> https://bugs.webkit.org/attachment.cgi?id=417995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417995&action=review

> Tools/CISupport/ews-build/steps.py:179
> +	   revision = self.getProperty('ews_revision',
self.getProperty('got_revision'))

This is actually the commit hash, right?

> Tools/CISupport/ews-build/steps.py:182
> +	   self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C',
'https://github.com/WebKit/Webkit', 'find', revision])

Should we consider invoking this with python3?