[webkit-reviews] review granted: [Bug 220762] BuildbotTriggerable should not update build requests from another triggerable. : [Attachment 417943] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 19 23:20:57 PST 2021
Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 220762: BuildbotTriggerable should not update build requests from another
triggerable.
https://bugs.webkit.org/show_bug.cgi?id=220762
Attachment 417943: Patch
https://bugs.webkit.org/attachment.cgi?id=417943&action=review
--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 417943
--> https://bugs.webkit.org/attachment.cgi?id=417943
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=417943&action=review
> Websites/perf.webkit.org/public/api/build-requests.php:53
> + $update_fields = array();
This should be either fields_to_update or updated_fields.
More information about the webkit-reviews
mailing list