[webkit-reviews] review granted: [Bug 220760] "Remove remaining non-standard CMYKA support from Canvas" : [Attachment 417938] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 220760: "Remove remaining non-standard CMYKA support from Canvas"
https://bugs.webkit.org/show_bug.cgi?id=220760

Attachment 417938: Patch

https://bugs.webkit.org/attachment.cgi?id=417938&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 417938
  --> https://bugs.webkit.org/attachment.cgi?id=417938
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417938&action=review

> Source/WebCore/ChangeLog:10
> +	   In r267645, most of the non-standard CMYKA taking functions on
`CanvasRenderingContext2D`
> +	   were removed, leaving only the `setShadow` overload left. This
finishes that removal and
> +	   cleans up some dead declarations that were left behind.

You’re implying but not stating here that we have some confidence no one is
relying on this setShadow overload that we left by accident.