[webkit-reviews] review granted: [Bug 220639] Web Inspector: BiDi issue on JavaScript evaluation result element : [Attachment 417763] PATCH
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 19 12:52:16 PST 2021
BJ Burg <bburg at apple.com> has granted review:
Bug 220639: Web Inspector: BiDi issue on JavaScript evaluation result element
https://bugs.webkit.org/show_bug.cgi?id=220639
Attachment 417763: PATCH
https://bugs.webkit.org/attachment.cgi?id=417763&action=review
--- Comment #5 from BJ Burg <bburg at apple.com> ---
Comment on attachment 417763
--> https://bugs.webkit.org/attachment.cgi?id=417763
PATCH
View in context: https://bugs.webkit.org/attachment.cgi?id=417763&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:400
> + // So that bidi algorithm won't be confused when a saved string has
RTL text
Nit: "so that the bidi"
Nit: WebKit style is to use a trailing period.
More information about the webkit-reviews
mailing list