[webkit-reviews] review granted: [Bug 220667] Update media state for active speech recognition as it uses audio capture : [Attachment 417882] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 11:53:33 PST 2021


youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 220667: Update media state for active speech recognition as it uses audio
capture
https://bugs.webkit.org/show_bug.cgi?id=220667

Attachment 417882: Patch

https://bugs.webkit.org/attachment.cgi?id=417882&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 417882
  --> https://bugs.webkit.org/attachment.cgi?id=417882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417882&action=review

> Source/WebCore/Modules/speech/SpeechRecognition.cpp:75
> +    auto& document = downcast<Document>(*context);

I am not sure this change is needed, we will anyway get a nullptr crash below.

> Source/WebCore/Modules/speech/SpeechRecognition.h:89
>      void suspend(ReasonForSuspension);

final as well?


More information about the webkit-reviews mailing list