[webkit-reviews] review granted: [Bug 220706] Introduce a MediaSessionGroupIdentifier : [Attachment 417830] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 11:51:41 PST 2021

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 220706: Introduce a MediaSessionGroupIdentifier

Attachment 417830: Patch


--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 417830
  --> https://bugs.webkit.org/attachment.cgi?id=417830

View in context: https://bugs.webkit.org/attachment.cgi?id=417830&action=review

> Source/WebCore/page/Page.cpp:2121
> +    return identifier ?
makeObjectIdentifier<MediaSessionGroupIdentifierType>(identifier->toUInt64()) :
MediaSessionGroupIdentifier { };

This will be called frequently, would it be worth caching the identifier in a
member variable?

More information about the webkit-reviews mailing list