[webkit-reviews] review canceled: [Bug 220736] REGRESSION(r271506): webkit-patch keyring integration is broken on Linux : [Attachment 417891] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has canceled Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 220736: REGRESSION(r271506): webkit-patch keyring integration is broken on
Linux
https://bugs.webkit.org/show_bug.cgi?id=220736

Attachment 417891: Patch

https://bugs.webkit.org/attachment.cgi?id=417891&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 417891
  --> https://bugs.webkit.org/attachment.cgi?id=417891
Patch

OK, webkitpy EWS is red. I didn't realize we still support python2. The new
version of python-keyring does not support python2. So I need to find an older
version that still supports python2, is new enough for the GitHub code to work,
and doesn't exhibit this secretstorage bug. Hi Jonathan, can you comment
regarding why you upgraded python-keyring? I assume you needed a newer version
of the library for... something? What exactly was required?

Then I'm not sure what is wrong with the python3 test. ModuleNotFoundError: No
module named 'monotonic' immediately after installing python-monotonic. Hm.